Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom header #5169

Merged
merged 1 commit into from Mar 3, 2014
Merged

Allow custom header #5169

merged 1 commit into from Mar 3, 2014

Conversation

Carreau
Copy link
Member

@Carreau Carreau commented Feb 20, 2014

Just because

$ ipython notebook --NotebookApp.webapp_settings='{"headers":{"Access-Control-Allow-Origin":"*"}}'

is usefull.

@dalejung
Copy link
Contributor

You are a wizard @Carreau. Just last night I realized that I needed to reboot dalejung/ipycli since it's no longer compatible with ipython master. Was going to open an issue asking the best way to port set_default_headers. And voila, here we are.

@takluyver
Copy link
Member

From the dev meeting: when we give examples of setting this header, we should show a more specific filtering (e.g. any port on localhost) rather than the 'allow any' wildcard which disables all CORS protection.

ellisonbg
ellisonbg reviewed Mar 1, 2014
View reviewed changes
IPython/nbconvert/templates/latex/base.tplx
@@ -20,7 +20,7 @@ This template does not define a docclass, the inheriting class must define this.
\usepackage{geometry} % Used to adjust the document margins
\usepackage{amsmath} % Equations
\usepackage{amssymb} % Equations
\usepackage[mathletters,combine]{ucs} % Extended unicode (utf-8) support
\usepackage[mathletters]{ucs} % Extended unicode (utf-8) support
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should be in a separate PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. thanks.

@dalejung dalejung mentioned this pull request Mar 1, 2014
Closed
@Carreau
Copy link
Member Author

Carreau commented Mar 1, 2014

rebased and fixed.

minrk added a commit that referenced this pull request Mar 3, 2014
@minrk
Merge pull request #5169 from Carreau/allow-cors
4fd7917 
Allow custom headers in tornado
@minrk minrk merged commit 4fd7917 into ipython:master Mar 3, 2014
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
@minrk
Merge pull request ipython#5169 from Carreau/allow-cors
af8c70a 
Allow custom headers in tornado
@Carreau Carreau deleted the allow-cors branch December 15, 2014 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Carreau @dalejung @takluyver @ellisonbg @minrk