handle missing output metadata in nbconvert #5187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Because we do (with 0.13) generate notebooks without metadata keys, I think we should fix this in nbconvert by not assuming there will always be a metadata key. |
|
This does handle the issue nbviewer has with the current IPython master. |
in nbconvert some old notebooks do not have this key defined
|
This now just protects nbconvert from missing output metadata, the actual issue. |
|
Looks good merging. |
ellisonbg
added a commit
that referenced
this pull request
Feb 22, 2014
handle missing output metadata in nbconvert
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
handle missing output metadata in nbconvert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this can only happen for notebooks written by 0.13-dev, but it's causing issues with nbconvert on some notebooks.