capture some logging/warning output in some tests #5203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
like @onlyif_cmds_exist, but pass if any is available instead of all
this could probably be made more general, but these were the two places I noticed log output.
|
And install nodejs on travis |
record is keyword only on Python 3
| @@ -11,7 +11,7 @@ before_install: | |||
| # Pierre Carrier's PPA for PhantomJS and CasperJS | |||
| - sudo add-apt-repository -y ppa:pcarrier/ppa | |||
| - sudo apt-get update | |||
| - sudo apt-get install pandoc casperjs | |||
| - sudo apt-get install pandoc casperjs nodejs | |||
There was a problem hiding this comment.
Do we need to install marked? Or does nbconvert use our included version?
There was a problem hiding this comment.
No, we only need nodejs. We use the marked shipped in ipython components.
There was a problem hiding this comment.
IIRC, it uses our included version...
There was a problem hiding this comment.
je je... I did not reload the page (I usually do it because of the Min's speed to answer 😉)...
| except ImportError as e: | ||
| # is_cmd_found uses pywin32 on windows, which might not be available | ||
| if sys.platform == 'win32' and 'pywin32' in str(e): | ||
| return skip("This test runs only if pywin32 and commands '{0}' " |
There was a problem hiding this comment.
Technically, one of the commands, but it's probably not important.
takluyver
added a commit
that referenced
this pull request
Feb 28, 2014
capture some logging/warning output in some tests
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
capture some logging/warning output in some tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few tests were generating log statements or warnings in iptest output. This captures those log statements and warnings.
It also adds the
@onlyif_any_cmd_existsdecorator, which is like@onlyif_cmds_exist, but pass if any is available instead of all, and then uses that to allow nbconvert html tests to run with node instead of pandoc.