use on-load event to trigger resizable images #5223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| setTimeout(function () { | ||
| // wrap image after it's loaded on the page, | ||
| // otherwise the measured initial size will be incorrect | ||
| img.on("load", function (){ |
There was a problem hiding this comment.
Is it possible that this ever gets called after the image has been loaded, so the callback is never called?
There was a problem hiding this comment.
No - we explicitly call it in between creating the element and appending to the document.
instead of timeout, which could get incorrect size information. closes ipython#5219
|
Looks good to me now. |
ellisonbg
added a commit
that referenced
this pull request
Mar 3, 2014
use on-load event to trigger resizable images
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
use on-load event to trigger resizable images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of timeout, which could get incorrect size information.
closes #5219