New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Javscript to base display priority list. #5243
Conversation
@@ -25,7 +25,7 @@ class NbConvertBase(LoggingConfigurable): | |||
Useful for display data priority that might be use by many transformers | |||
""" | |||
|
|||
display_data_priority = List(['html', 'application/pdf', 'svg', 'latex', 'png', 'jpg', 'jpeg' , 'text'], | |||
display_data_priority = List(['html', 'javascript', 'application/pdf', 'svg', 'latex', 'png', 'jpg', 'jpeg' , 'text'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the live notebook, javascript comes first. Is this different on purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No not at all, just lack of that knowledge. I'll go ahead and change it.
Pinging @jakevdp |
Add Javscript to base display priority list.
Add Javscript to base display priority list.
This effectively adds it to the HTML output since every other exporter explicitly overrides the display priority list.
closes #5225