Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing class def for TimeoutError #5265

Merged
merged 2 commits into from Mar 3, 2014
Merged

Conversation

ellisonbg
Copy link
Member

In launchnotebook.py we were missing a definition of TimeoutError. This was causing weird effects when some tests fail.

@takluyver
Copy link
Member

Oops, that would be me. TimeoutError is a builtin on Python 3. Can you add a comment that the class definition will be unnecessary when we don't need to support Python 2?

@ellisonbg
Copy link
Member Author

Ok I have added the comment. Thanks!

On Mon, Mar 3, 2014 at 2:45 PM, Thomas Kluyver notifications@github.comwrote:

Oops, that would be me. TimeoutError is a builtin on Python 3. Can you
add a comment that the class definition will be unnecessary when we don't
need to support Python 2?

Reply to this email directly or view it on GitHubhttps://github.com//pull/5265#issuecomment-36570438
.

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

takluyver added a commit that referenced this pull request Mar 3, 2014
Missing class def for TimeoutError
@takluyver takluyver merged commit dfd5cb1 into ipython:master Mar 3, 2014
@ellisonbg ellisonbg deleted the timeout-error branch March 6, 2014 22:58
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants