check that PIL can save JPEG to BytesIO #5277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as far as I can tell, this is a bug in PIL that is fixed in Pillow.
|
Looks OK. Do we want to pull this out one day when PIL is properly dead? i.e. should we leave a comment explaining why it's needed? |
|
I added a comment. I think it might also be possible for this to fail if PIL/pillow does not link libjpeg (would presumably be a different error), but I'm not sure about that. |
|
The code looks good, and I have confirmed that it fixes in the test failure on Anaconda. I am +1 for merging this. Thanks! |
takluyver
added a commit
that referenced
this pull request
Mar 5, 2014
check that PIL can save JPEG to BytesIO
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
check that PIL can save JPEG to BytesIO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as far as I can tell, this is a bug in PIL that is fixed in Pillow.
addresses one of the test failures in #5264