OutputArea.append_type functions are not prototype methods #5295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like there's something funny about the js context in which the tests run. Will investigate. |
| "text/latex" : OutputArea.prototype.append_latex, | ||
| "application/javascript" : OutputArea.prototype.append_javascript, | ||
| "application/pdf" : OutputArea.prototype.append_pdf | ||
| "text/plain" : append_text, |
There was a problem hiding this comment.
just as a quick glance append_stream uses this.append_text, so either fix there or keep this one attached to output area?
|
PR looks fine and makes sense otherwise. |
|
I am confused, most of these methods use |
|
Entries in append_map are called via |
|
OK, thanks for the clarification. I have looked at this and tested it interactively. Looks fine, merging. |
ellisonbg
added a commit
that referenced
this pull request
Mar 10, 2014
OutputArea.append_type functions are not prototype methods
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
OutputArea.append_type functions are not prototype methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are registered in OutputArea.append_map. Overriding them requires only replacing keys in this dict. Prototype methods imply that overriding the prototype will change behavior, which is not true.