Improve assignment regex to match more tuple unpacking syntax #5321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks fine. However, I am always wary to change things like this right before a release as there can be so many edge cases. I don't have any particular edge cases in mind, just general vague uneasiness. Do you think it would be possible to add more tests for the existing behaviors to give us a higher degree of confidence this isn't creating any regressions? |
|
@ellisonbg , I've added some more tests. Do you think they give us enough confidence? |
|
Yes, that is better. Thanks! Let's wait for Travis and then go ahead and merge-I will be at a meeting by the time Travis is done :( |
takluyver
added a commit
that referenced
this pull request
Mar 10, 2014
Improve assignment regex to match more tuple unpacking syntax
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Improve assignment regex to match more tuple unpacking syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, unpacking with a trailing comma (
a, =) and Python 3 extended unpacking (a, *rest =).Closes gh-5305