do not install less sources #5359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # add 'static/' prefix to exclusions | ||
| excludes = [pjoin('static', ex) for ex in excludes] | ||
| # add 'ex/*' to exclusions, so that descendents are also excluded | ||
| excludes.extend([pjoin(ex, '*') for ex in excludes]) |
There was a problem hiding this comment.
Reading this, I find the process of building a list, modifying it, and extending it with a modified copy of itself confusing. Could we get rid of one or both modification steps and bear a little bit of repetition for the sake of clarity?
only their css build results are used after install
|
just tested it, works great. (though i thought it didn't work for a long time, because I had stale files in my |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
do not install less sources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only their css build results are used after install, so there's no need to include them in installs / wheels.