Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary onload hack from mathjax macro #5375

Merged
merged 1 commit into from Mar 20, 2014

Conversation

minrk
Copy link
Member

@minrk minrk commented Mar 18, 2014

This is still up for discussion.

@damianavila can you provide an example where the hack is necessary? It seems it was added in a PR only meant to consolidate files without changing any behavior. I can find no report of the problems this claims to fix. I very much doubt that it is the right fix for whatever problem it addresses, so I would like to try to find the right solution.

@ivanov
Copy link
Member

ivanov commented Mar 18, 2014

IIRC @matthew-brett recently wrestled with this hack, as well.

@damianavila
Copy link
Member

The hack was originally introduced when IPython.nbconvert was an standalone app...
Surprisingly, I have tested your branch I do not see the problem anymore. The problem was essentially a bad rendering of the math symbols, and it had a random nature (a kind of heisenbug), only fixed by the hack of loading mathjax at the very end...
Anyway a lot of things changes, not only in IPython.nbconvert, but also in reveal.js, and the bug seems to be gone.
To conclude +1 to merge this one... because I can not replicate the problem anymore (which is a great notice, btw).
Thanks for start the discussion and "force" me to check this again 😉

@ellisonbg
Copy link
Member

I don't recall why we put this hack in originally. But I am fine with merging this and seeing what happens. MathJax should work fine without this hack - for sure.

@minrk
Copy link
Member Author

minrk commented Mar 20, 2014

Merging away, we'll see if someone actually sees an issue from this. nbviewer has never had this hack, and it's by far the most used case for nbconvert + mathjax.

minrk added a commit that referenced this pull request Mar 20, 2014
remove unnecessary (?) onload hack from mathjax macro
@minrk minrk merged commit 4700b8b into ipython:master Mar 20, 2014
@minrk minrk deleted the remove-mathjax-hack branch March 20, 2014 21:36
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
remove unnecessary (?) onload hack from mathjax macro
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants