don't instantiate Application just for default logger #5379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's unlikely to happen in IPython itself, but can happen if config loaders are used elsewhere.
|
It looks OK, but do we want to leave it until after 2.0 now in case it has some unexpected side effects? |
|
I'm fine either way. I can't imagine what side effects it would have, but I've said that before. |
|
I don't see any likely ones either. And I guess we won't find out until we merge it. Ah, let's just do it - if there are problems, we'll fix them. |
takluyver
added a commit
that referenced
this pull request
Mar 19, 2014
don't instantiate Application just for default logger
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
don't instantiate Application just for default logger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's unlikely to come up in IPython itself, but can happen if config loaders are used elsewhere.
closes #5378