better log message in deprecated files/ redirect #5389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| if not os.path.exists(files_path): | ||
| self.log.warn("Deprecated files path: %s", path) |
There was a problem hiding this comment.
Maybe add a leading / to the word files here to emphasize this is specifically the URL /files not some generic "files" notion.
There was a problem hiding this comment.
Sure. I added a trailing / (not leading, because leading / was never correct - files/ URLs always had to be relative links)
|
Great, merging. |
ellisonbg
added a commit
that referenced
this pull request
Mar 20, 2014
better log message in deprecated files/ redirect
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
better log message in deprecated files/ redirect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.