finish PR #5333 #5390
Merged
finish PR #5333 #5390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -102,10 +102,21 @@ def is_hidden(abs_path, abs_root=''): | |||
| if any(part.startswith('.') for part in inside_root.split(os.sep)): | |||
| return True | |||
|
|
|||
| # check that dirs can be listed | |||
| if os.path.isdir(abs_path): | |||
There was a problem hiding this comment.
Maybe a comment here about what situations this covers (IOW, when can a dir be non-listable.)
|
Just one minor comment, then ready for merging. |
is_hidden is called with files, not just dirs
|
Great, merging. |
ellisonbg
added a commit
that referenced
this pull request
Mar 20, 2014
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The missing bit was listdir being called on files, not just dirs