Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix numeric verification for Int and Float text widgets. #5444

Merged
merged 1 commit into from Mar 31, 2014

Conversation

jdfreder
Copy link
Member

Allow '.', '-.', and '-' even though without numbers, they cannot be parsed. This makes these values parse as 0.

closes #5443

@ellisonbg
Copy link
Member

We might as well also handle '+' and '+.' as well.

@jdfreder
Copy link
Member Author

Ahhh, good point, one sec

@jdfreder
Copy link
Member Author

I --amended the commit with + and +. support.

@jdfreder jdfreder added this to the 2.0 milestone Mar 28, 2014
minrk added a commit that referenced this pull request Mar 31, 2014
Fix numeric verification for Int and Float text widgets.
@minrk minrk merged commit 0ee2a44 into ipython:master Mar 31, 2014
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Fix numeric verification for Int and Float text widgets.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Int and Float Widgets don't allow negative signs
3 participants