Fix starting notebook server with file/directory at command line. #5464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The base class implementation of parse_command_line uses update_config, which ensures that the change event fires for the config traitlet. This copies that. Closes ipythongh-5460
minrk
added a commit
that referenced
this pull request
Mar 28, 2014
Fix starting notebook server with file/directory at command line.
|
@minrk Any idea why this was failing for me but not for you? |
|
I have a default NotebookApp.notebook_dir in config. This resulted in a config_changed event firing later, so the explicit |
|
OK, that makes sense. |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Fix starting notebook server with file/directory at command line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base class implementation of parse_command_line uses update_config, which ensures that the change event fires for the config traitlet. This copies that.
Closes gh-5460