Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use milestones to indicate backport #5498

Merged
merged 1 commit into from Apr 2, 2014
Merged

Conversation

minrk
Copy link
Member

@minrk minrk commented Apr 2, 2014

instead of labels.

I think this will more clearly indicate what's new in what releases, plus it's way easier to show pull requests with a specific milestone than it is with a specific label.

@minrk minrk modified the milestones: 2.1, 2.0 Apr 2, 2014
@takluyver
Copy link
Member

👍

@ellisonbg
Copy link
Member

I am fine deferring this decision to @minrk, but just to play devil's
advocate...

Originally the logic for change is that it wasn't easy to use labels for
pull requests. But since then, GitHub has changed the UIs for all of that
and now using labels with PRs is easy. With these changes why do milestones
still make more sense?

On Wed, Apr 2, 2014 at 11:02 AM, Thomas Kluyver notifications@github.comwrote:

[image: 👍]

Reply to this email directly or view it on GitHubhttps://github.com//pull/5498#issuecomment-39362938
.

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

@minrk
Copy link
Member Author

minrk commented Apr 2, 2014

Adding labels to PRs is easy, but there is still no way to view only PRs with a specific label (you can view all Issues with a label, but not just PRs).

Further, I think this better communicates when each change is actually available in a release - as we were doing it previously, we had a clear indication of what's different between 2.0 and 1.0, but that's not actually what anybody cares about. What people want to know is the difference between 2.0 and 1.2.1, but that's not easy to see with our current labeling scheme (Issues with milestone 2.0, but without any backport label).

I don't feel super strongly, but I think it's worth a try.

@ellisonbg
Copy link
Member

All true, let's give it a shot.

On Wed, Apr 2, 2014 at 11:48 AM, Min RK notifications@github.com wrote:

Adding labels to PRs is easy, but there is still no way to view only PRs
with a specific label (you can view all Issues with a label, but not just
PRs).

Further, I think this better communicates when each change is actually
available in a release - as we were doing it previously, we had a clear
indication of what's different between 2.0 and 1.0, but that's not actually
what anybody cares about. What people want to know is the difference
between 2.0 and 1.2.1, but that's not easy to see with our current labeling
scheme (Issues with milestone 2.0, but without any backport label).

I don't feel super strongly, but I think it's worth a try.

Reply to this email directly or view it on GitHubhttps://github.com//pull/5498#issuecomment-39368420
.

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

@minrk
Copy link
Member Author

minrk commented Apr 2, 2014

I've updated the wiki

minrk added a commit that referenced this pull request Apr 2, 2014
use milestones to indicate backport
@minrk minrk merged commit 55dccee into ipython:master Apr 2, 2014
@minrk minrk deleted the backport-milestones branch April 2, 2014 19:25
minrk added a commit that referenced this pull request Apr 9, 2014
instead of labels.

I think this will more clearly indicate what's new in what releases, plus it's way easier to show pull requests with a specific milestone than it is with a specific label.
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants