Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HasTraits pickleable #5554

Merged
merged 1 commit into from Apr 8, 2014
Merged

Conversation

minrk
Copy link
Member

@minrk minrk commented Apr 7, 2014

The main change is storing method names instead of functions in _trait_dyn_inits. These functions were failing to pickle.

The main change is storing method names instead of functions in `trait_dyn_inits`.
These functions were failing to pickle.
@takluyver
Copy link
Member

Looks good to me, and Travis is happy.

takluyver added a commit that referenced this pull request Apr 8, 2014
@takluyver takluyver merged commit 6ab319b into ipython:master Apr 8, 2014
@minrk minrk added this to the 2.1 milestone Apr 9, 2014
@minrk minrk deleted the pickle-traitlets2 branch April 16, 2014 21:33
minrk added a commit that referenced this pull request Apr 16, 2014
The main change is storing method names instead of functions in `_trait_dyn_inits`. These functions were failing to pickle.
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants