New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide more help if lessc is not found. #5633
Conversation
And this is minor but a comment in the file indicates lessc@1.5.0 is excluded by the version check, but it isn't. |
Do you want to fix the check for 1.5? It should be just changing |
@minrk - I don't understand.
for |
1.5.0 should be excluded |
Thanks, I'll figure out what's going on and update the PR. |
Oh, I'm an idiot. Thanks. |
* lessc@1.5.0 now invalid * more help if lessc not found
lessc output changes dramatically across versions, so pinning the version helps to avoid massive diffs with small CSS changes. We will probably pin a later version during the 3.0 cycle. |
@minrk - I redid the commit, this is ready for review again. |
Provide more help if lessc is not found.
thanks |
A slightly more useful error message. I used a ValueError to match the other exceptions, but I think OSError might be a more appropriate exception. Addresses: #5632
Provide more help if lessc is not found.
A slightly more useful error message.
I used a ValueError to match the other exceptions, but I think OSError might be a more appropriate exception.
Addresses: #5632