Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use common names in require decorators #5699

Merged
merged 1 commit into from Apr 22, 2014
Merged

Conversation

minrk
Copy link
Member

@minrk minrk commented Apr 22, 2014

causes kwarg collisions if the depended-upon function has the same name.

closes #5698

causes kwarg collisions if the depended-upon function has the same name.
takluyver added a commit that referenced this pull request Apr 22, 2014
don't use common names in require decorators
@takluyver takluyver merged commit 967090d into ipython:master Apr 22, 2014
@porterjamesj
Copy link
Contributor

thanks!

@minrk minrk added this to the 2.1 milestone Apr 22, 2014
@minrk minrk deleted the badf branch April 22, 2014 22:18
takluyver added a commit that referenced this pull request May 7, 2014
causes kwarg collisions if the depended-upon function has the same name.

closes #5698
takluyver added a commit that referenced this pull request May 7, 2014
causes kwarg collisions if the depended-upon function has the same name.

closes #5698
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
don't use common names in require decorators
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't require a function named f
3 participants