monkeypatch inspect.findsource only when we use it #5712
Merged
+12
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rather than all the time, so it doesn't affect use outside IPython
|
The original bug is #1456, which appears to still be fixed after moving the monkeypatch to the context manager. It's possible that there are other affected cases, though. |
|
It seems somewhat redundant to define a context manager in order to define a decorator. Can we just use one or the other? |
|
Yeah, that's a bit silly. Context manager removed. |
takluyver
added a commit
that referenced
this pull request
Apr 25, 2014
monkeypatch inspect.findsource in a context manager
minrk
changed the title
takluyver
added a commit
that referenced
this pull request
May 7, 2014
rather than all the time, so it doesn't affect use outside IPython closes #5710
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
monkeypatch inspect.findsource in a context manager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rather than all the time, so it doesn't affect use outside IPython
closes #5710