Fix check for pickling closures #5762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -34,12 +21,11 @@ def code_ctor(*args): | |||
| return types.CodeType(*args) | |||
|
|
|||
| def reduce_code(co): | |||
| if co.co_freevars or co.co_cellvars: | |||
| raise ValueError("Sorry, cannot pickle code objects with closures") | |||
| print(co.co_freevars, co.co_cellvars) | |||
There was a problem hiding this comment.
I guess this should be taken out?
There was a problem hiding this comment.
Holy crap. If it weren't for you guys reviewing my code, I would have accidentally committed dozens of inappropriate print statements to IPython.
Fixed.
Only closures on the outer-most function don't work. Internal closures that fully resolve should still be fine.
takluyver
added a commit
that referenced
this pull request
May 1, 2014
Fix check for pickling closures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #5761 I added actual support for closures, which I don't want to backport. But I do want 2.x to get this simpler fix for the bug where we are too aggressive about preventing pickling of closures. Only closures on the outer-most function don't work; internal closures that fully resolve should still be fine, which comes up in often in list comprehensions in Python 3.