fix cursor keys in long lines wrapped in markdown #5768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 to backport ! |
|
Note sure what it means, but I love the long branch name 😜 Checked it out, it fixes the bug for me! Thanks Paul! 🍰 for you |
|
@jdfreder - He may be referring to a famous cheat code from slightly before your time :) |
|
Kids, today! |
|
Don't feel bad, I am older than all of you can didn't get the reference... |
|
I don't need stinky cheats to win a game 😉 Nice art @ivanov , I saw the   ninja edit hehe |
|
Ahhh old iddqd idkfa. You do not find any more idspispopd now days.M Envoyé de mon iPhone
|
|
i'm done here and Jon reported that it fixed the issue for him. Who's feeling green? |
minrk
added a commit
that referenced
this pull request
May 6, 2014
fix cursor keys in long lines wrapped in markdown
takluyver
added a commit
that referenced
this pull request
May 7, 2014
closes #5467 pinging @ellisonbg and @jdfreder who reported the bug
minrk
added a commit
that referenced
this pull request
Jul 7, 2014
Extra change on top of @ivanov pr #5768 to have more consistent handling of visual lines. In a long wrapped line End/Cmd-Right will go to the end of the visual line which seem more logical. Cmd-Left beginning of line. I did note rebind Ctrl-Left because there is already custom logic in code mirror for "smart" beginning of line.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
fix cursor keys in long lines wrapped in markdown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5467
pinging @ellisonbg and @jdfreder who reported the bug