unify visual line handling

[Carreau]

Extra change on top of @ivanov pr #5768 to have more consistent handling of visual lines.

In a long wrapped line End/Cmd-Right will go to the end of the visual line which seem more logical.
Cmd-Left beginning of line. I did note rebind Ctrl-Left because there is already custom logic in code mirror for "smart" beginning of line.

[ivanov]

my sense is that cell.js isn't the right place for this (also it's an OS X specific key binding that you're inserting in for everyone).

There's an if (platform === 'MacOS') { block in keyboardmanager.js that might be more appropriate for a change like this?

[Carreau]

(also it's an OS X specific key binding that you're inserting in for everyone)

IIUC Cmd only exist on macs so this should not have effect on non-macs.

There's an if (platform === 'MacOS') { block in keyboardmanager.js that might be more appropriate for a change like this?

I can try, but as I understand it keyboardmanager.js handle only what need to interact with IPython, and otherwise lets go through what is codemirror specific. Why would we want people to configure codemirror bindings with our custom keyboard handler when codemirror already have a number of commands that are already availlable.

[Carreau]

codemirror demo: http://codemirror.net/demo/indentwrap.html

[Carreau]

From the dev meeting this should be tested on a non-osx machine and we might want to bring the default upstream in codemirror.

[damianavila]

codemirror demo: http://codemirror.net/demo/indentwrap.html

This demo is Codemirror 4.1, I do not know if it is the same in Codemirror 3... I suppose it is, just saying if you see some inconsistencies...

[takluyver]

Dev meeting: Just check on Windows, then merge.

[minrk]

Seems to behave sensibly on Windows. Merging.