Drop log level to info for Qt console shutdown #5807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minrk
added a commit
that referenced
this pull request
May 8, 2014
Drop log level to info for Qt console shutdown
|
High log level was probably left over from debugging this, since the shutdown sequence of the qtconsole is an elaborate nightmare of messages and events. |
minrk
added a commit
that referenced
this pull request
May 8, 2014
At present, shutting down the Qt console displays this message in the terminal:
```
[IPythonQtConsoleApp] WARNING | shutdown: {'status': 'ok', 'restart': False}
```
I don't think this needs to be a warning - it's responding correctly to a user action. Info messages are not shown by default, so this change silences the message in the default case.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
…level Drop log level to info for Qt console shutdown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, shutting down the Qt console displays this message in the terminal:
I don't think this needs to be a warning - it's responding correctly to a user action. Info messages are not shown by default, so this change silences the message in the default case.