Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in v2 convert #5835

Merged
merged 1 commit into from May 14, 2014
Merged

fix typo in v2 convert #5835

merged 1 commit into from May 14, 2014

Conversation

minrk
Copy link
Member

@minrk minrk commented May 10, 2014

resulted in NameError on orig_version because arg name is from_version

@minrk minrk added this to the 2.1 milestone May 10, 2014
@@ -35,7 +35,8 @@ def upgrade(nb, from_version=1):
orig_version : int
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docstring should be updated.

resulted in NameError on orig_version because arg name is from_version
takluyver added a commit that referenced this pull request May 14, 2014
@takluyver takluyver merged commit 09d3a4e into ipython:master May 14, 2014
@minrk minrk deleted the v2-typo branch May 16, 2014 17:12
minrk added a commit that referenced this pull request May 16, 2014
resulted in NameError on orig_version because arg name is from_version
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants