Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Firefox-specific CSS workaround #5843

Merged
merged 1 commit into from May 15, 2014
Merged

remove Firefox-specific CSS workaround #5843

merged 1 commit into from May 15, 2014

Conversation

minrk
Copy link
Member

@minrk minrk commented May 12, 2014

The bug being worked around appears to be fixed either in CodeMirror or Firefox (tested with FF 29).

Importantly, the workaround appears to introduce incorrect behavior

closes #5192
closes #5364

The bug being worked around appears to be fixed either in CodeMirror or Firefox (tested with FF 29).

Importantly, the workaround appears to *introduce* incorrect behavior

closes ipython#5192
closes ipython#5364
@jdfreder
Copy link
Member

Does this fix the other flexbox problems- i.e. #5675 ?

@minrk
Copy link
Member Author

minrk commented May 12, 2014

No, just the scrollbar stuff. I would like folks to test it - I was able to reproduce the scrollbar bad behavior, and removing this CSS did fix it, but I'm not entirely certain about the scope of affected cases. It doesn't appear that flexbox is relevant to these scrollbar issues at all.

As for the flexbox problems, I can't seem to replicate them in either Firefox or Chrome. Can you provide a test case that still reproduces the issue in master? Neither the steps in #5675 nor in #5612 produce empty space in master.

@jdfreder
Copy link
Member

To reproduce the lingering empty space flexbox problem:
Use OSX with Chrome 24

  1. New notebook.
  2. Type multiple lines in cell that is created for you.
  3. Delete lines, note cell size doesn't change.

It's interesting to note that I'm not able to reproduce on Linux w/ Chrome 21..... hmmmm

@ellisonbg
Copy link
Member

I am still seeing this issue...

On Mon, May 12, 2014 at 3:01 PM, Jonathan Frederic <notifications@github.com

wrote:

To reproduce the lingering empty space flexbox problem:
OSX
Chrome 24

  1. New notebook.
  2. Type multiple lines in cell that is created for you.
  3. Delete lines, note cell size doesn't change.

It's interesting to note that I'm not able to reproduce on Linux w/ Chrome
21..... hmmmm


Reply to this email directly or view it on GitHubhttps://github.com//pull/5843#issuecomment-42894192
.

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

@minrk
Copy link
Member Author

minrk commented May 12, 2014

Do you mean Chrome 34? 24 is a year old. This doesn't seem to be reproducible on Chrome 36.0.1976.2.

@ellisonbg what browser/version?

@jdfreder
Copy link
Member

Do you mean Chrome 34? 24 is a year old

Yes, sorry

@minrk
Copy link
Member Author

minrk commented May 12, 2014

Okay. I can reproduce it in Chrome 34 (stable), but not Chrome 35 (β), 36 (dev), Firefox 29, or Safari 7.0.3. That suggests it's a browser bug, and better yet an already fixed browser bug. In that case, my inclination is to leave it and wait for the next Chrome release, which should be in a couple of weeks.

@minrk minrk added this to the 2.1 milestone May 12, 2014
minrk added a commit that referenced this pull request May 15, 2014
remove Firefox-specific CSS workaround
@minrk minrk merged commit 120fad1 into ipython:master May 15, 2014
@minrk minrk deleted the ff-css branch May 15, 2014 17:55
@mbewley
Copy link

mbewley commented May 15, 2014

I still see this on Firefox 29 (Ubuntu 14.04 version), and IPython 2.0.

@jdfreder
Copy link
Member

I still see this on Firefox 29 (Ubuntu 14.04 version), and IPython 2.0.

The fix is in master, the next release to include it will be 2.1 .

minrk added a commit that referenced this pull request May 16, 2014
The bug being worked around appears to be fixed either in CodeMirror or Firefox (tested with FF 29).

Importantly, the workaround appears to *introduce* incorrect behavior

closes #5192
closes #5364
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
remove Firefox-specific CSS workaround
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants