Remove / from route of TreeRedirectHandler. #6117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When base_url is set, navigating to http://{url}/{base_url} returns 404
This is due to the TreeRedirectHandler only picking up
http://{url}/{base_url}/ and the trailing slash handler being set to
{base_url}/.*/.
This change will cause http://{url}/{base_url} to correctly redirect to
http://{url}/{base_url}/tree, as expected.
|
Thanks! |
minrk
added a commit
that referenced
this pull request
Jul 11, 2014
Remove / from route of TreeRedirectHandler.
minrk
added a commit
that referenced
this pull request
Jul 24, 2014
When base_url is set, navigating to http://{url}/{base_url} returns 404
This is due to the TreeRedirectHandler only picking up http://{url}/{base_url}/ and the TrailingSlashHandler being set to {base_url}/.*/.
This change will cause http://{url}/{base_url} to correctly redirect to http://{url}/{base_url}/tree, as expected.
...
minrk
added a commit
to minrk/ipython
that referenced
this pull request
Aug 18, 2014
before ipython#6117, only `/base_url/` worked, after ipython#6117, only `/base_url worked, after this PR, both should work.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Remove / from route of TreeRedirectHandler.
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
before ipython#6117, only `/base_url/` worked, after ipython#6117, only `/base_url worked, after this PR, both should work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When base_url is set, navigating to http://{url}/{base_url} returns 404
This is due to the TreeRedirectHandler only picking up http://{url}/{base_url}/ and the TrailingSlashHandler being set to {base_url}/.*/.
This change will cause http://{url}/{base_url} to correctly redirect to http://{url}/{base_url}/tree, as expected.
When base_url is not set, the TrailingSlashHandler will redirect http://{url}/ to http://{url}, so this will not affect that situation.
This issue affects 2.x and 3.x.