Use appnope in qt and wx gui support from the terminal; closes #6189 #6321
Conversation
…n#6189 On Mavericks, the qt and wx gui support was unusable from the ipython console in a terminal. Using nope() in enable_qt4 and enable_wx, and reversing with nap() in disable_qt4 and disable_wx, solves the problem.
|
I have tested this only with qt, not with wx. |
|
Confirming that this resolves the issue with both the wx and qt event loop integration. |
| from IPython.lib.inputhookwx import inputhook_wx | ||
| from IPython.external.appnope import nope |
There was a problem hiding this comment.
I think this wants to be wrapped in a check for OS X 10.9, as in loop_wx (skip the kernel._ part, since that doesn't apply in inputhook).
There was a problem hiding this comment.
This check is already included in appnap.init; nope() and nap() are dummied out if not in OS X 10.9.
There was a problem hiding this comment.
Fair enough. I forgot I had done that.
|
This makes perfect sense. I made one comment about protecting the use of appnope to only OS X ≥ 10.9 like we do elsewhere, but otherwise AOK. We do try to avoid whitespace-stripping commits, but this one is small enough that I don't mind. |
Use appnope in qt and wx gui support from the terminal; closes #6189
|
Oh, crap. I didn't realize this was a PR against 2.x until too late. I shouldn't have merged it. We don't normally accept any PRs against 2.x, we only accept PRs against master, which we later backport to 2.x. |
|
Opened against master as #6325. |
On Mavericks, the qt and wx gui support was unusable from the
ipython console in a terminal. Using nope() in enable_qt4 and
enable_wx, and reversing with nap() in disable_qt4 and disable_wx,
solves the problem.