Rename abort_queues --> _abort_queues

[dhirschfeld]

No description provided.

[dhirschfeld]

Seems there's some whitespace noise. I'll force-push a fix for that.

Isn't the recommended practice to strip trailing whitespace though?

[Carreau]

Seems there's some whitespace noise. I'll force-push a fix for that.

Thanks !

Isn't the recommended practice to strip trailing whitespace though?

Only on lines adjacent to actual changes, otherwise it's hard to use git blame to track reason of changes.

[dhirschfeld]

Missed one line at the bottom, but hopefully that's acceptable!

[Carreau]

Missed one line at the bottom, but hopefully that's acceptable!

It's compensated by the typo in the docstring :-)

[minrk]

Isn't the recommended practice to strip trailing whitespace though?

No, actually not ever.

[minrk]

Missed one line at the bottom, but hopefully that's acceptable!

Yes, totally fine. We don't mind any small whitespace changes, especially around the code you are working on. It's just a good idea to avoid making large unrelated changes.

@dhirschfeld would you be willing to squash your two commits into one? This PR now has two large whitespace changes, even though the net diff doesn't have any.

[dhirschfeld]

Squashed!

[minrk]

Thanks for putting up with our foibles.

[dhirschfeld]

Not a problem - I can fully appreciate the need to have strong and consistent development practices.