Trim anchor link in heading cells, fixes #6324 #6483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dont....want... to rehearse... will review... PR... +1 Need backport ? |
|
@Carreau, do we need to block you from commenting until your defence is done? 😉 good luck! |
minrk
added a commit
that referenced
this pull request
Sep 16, 2014
Trim anchor link in heading cells, fixes #6324
|
@takluyver technically it was already done by the time you wrote this comment. You were sleeping tight in your beds when I was already opening champagne. I'll bring a bottle on Thursday dev meeting. Envoyé de mon iPhone
|
|
Awesome! Congratulations. |
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
Trim anchor link in heading cells, fixes ipython#6324
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #6324, which was really irritating me 😃 I used
.trim()as suggested by @minrk.