backport nbformat v4 to 2.x #6778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it also needs to be added to the dict of versions in |
|
Yup, I'm working on this now. A few shims need to be added, and I'm including some basic tests. |
minrk
force-pushed
the
2.x-nbformat-4
branch
3 times, most recently
from
c951181
to
eb4dd70
Compare
|
reading v4 notebooks in 2.x appears to be working fine now |
|
👍 |
| with self.fopen(u'test4.ipynb', u'r') as f: | ||
| nb = read(f, u'json') | ||
|
|
||
| # Check that the notebook was upgraded to the latest version automatically. |
There was a problem hiding this comment.
this comment is misleading - it's downgrading from the latest format to the current version.
There was a problem hiding this comment.
yup, missed that in copy/paste. Fixed.
|
The first commit should have no changes to individual files, just |
- add v4 to reader - validation is not backported - update some tests to reflect this - test opening v4 notebooks
in notebook.js dialogs, which can now be triggered by nbformat 4 from the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check out nbformat v4 for 2.x
still to do: