display='none' has no effect with children Accordion's children

[hainm]

Hi,

Please see below.

Code

tmpnb_ngl.txt

[hainm]

If I us Tab, I got what I expected (hiding 3rd 'z' widget)

[hainm]

I am using v5.2.2, not dec version.

[gnestor]

widget.children[-1] is a ipywidgets.widgets.widget_output.Output class vs. a ipywidgets.widgets.widget_int.IntSlider, so setting the display value of that will not affect the 3rd slider.

So, widget.children[-2].layout.display = 'none' will hide the 3rd slider. I suggest using the visibility property primarily because according to the docs, display "must be equal to ‘flex’ or ‘inline-flex’", although display = 'none' will work.

[hainm]

@gnestor I meant the behavior is different between using Tab and Accordion. With Tab, I can set display=None while I can not with Accordion. I don't see why they should be different.

There is a reason I want to use display=None in this case: Supposed I have an widget that is about 1/4-1/2 of the notebook. Using visibility does not collapse it if user does not need it, so there will be wasted blank page. Using display=None will collapse that.

[jasongrout]

This looks like a bug in the Tab widget, that it's hiding the wrong widget. Looks like the bug is already fixed in master, though:

Changing the line to widget.children[-2].layout.display='none' works as expected, though, and it hides the z slider.

[jasongrout]

Closing since it seems to be fixed in master. Please reopen if doing .children[-2] as above doesn't work for you.

[gnestor]

@jasongrout I can verify that Accordion is not responding to changes to its children's layout. I created a test notebook to reproduce.

[jasongrout]

I'll see your screenshot and raise you one of my own notebook :)

The accordion you show in your screenshot is not the one we recently merged, I think - the 'Page 0' is blue in the old accordion, but plain black in the new rewrite.

[gnestor]

You called my bluff! I was wondering why the tabs were still looking like before. Ok, verified that it's currently working as expected master.