Work on deprecation warnings #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of deprecated APIs
use warn_explicit to point directly to method definitions, rather than event-triggering code, which is not informative.
Closed
|
wow, I did not know one could do this with |
|
Yup, I think this one's ready. There's more thinking to do on #149, since the code is not currently backward-compatible. |
SylvainCorlay
added a commit
that referenced
this pull request
Dec 18, 2015
Work on deprecation warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
init(**metadata)warningwarn_explicitto point to deprecated magic method definitions,instead of the event-triggering code, which isn't relevant.
(includes #149)