Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passthrough unused args to super.__init__ #175

Merged
merged 1 commit into from
Feb 17, 2016
Merged

Conversation

minrk
Copy link
Member

@minrk minrk commented Feb 17, 2016

only those not consumed by trait value-setting

for proper cooperative inheritance

finishes fixing #113

@minrk minrk mentioned this pull request Feb 17, 2016
@minrk minrk added this to the 4.2 milestone Feb 17, 2016
@NeilGirdhar
Copy link

@minrk Wow! That was fast, thank you!!

@minrk
Copy link
Member Author

minrk commented Feb 17, 2016

We aim to please.

@NeilGirdhar
Copy link

@minrk lol :) Don't forget to remove your debug print statement

only those not consumed by trait value-setting

for better inheritance
@minrk
Copy link
Member Author

minrk commented Feb 17, 2016

...I don't know what you are talking about....

@rmorshea
Copy link
Contributor

I wish you could like comments (e.g. ^) on GitHub, it'd be fun and useful.

minrk added a commit that referenced this pull request Feb 17, 2016
passthrough unused args to super.__init__
@minrk minrk merged commit 534e58f into ipython:master Feb 17, 2016
@minrk minrk deleted the super-args branch February 17, 2016 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants