Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Use own logger for the package rather than the root logger. #233

Merged
merged 1 commit into from
May 27, 2016
Merged

ENH: Use own logger for the package rather than the root logger. #233

merged 1 commit into from
May 27, 2016

Conversation

rkern
Copy link
Contributor

@rkern rkern commented May 26, 2016

Libraries should not attempt to configure the root logger. The standard best practice is to use a namespaced logger for the package and to add a NullHandler to it.

@minrk minrk merged commit d258551 into ipython:master May 27, 2016
@rkern rkern deleted the fix/logging branch May 27, 2016 10:37
@rkern
Copy link
Contributor Author

rkern commented May 27, 2016

Thanks!

This was referenced May 27, 2016
Closed
Closed
@minrk minrk modified the milestone: 4.3 Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rkern @minrk