feat(cfg): write also enum choices when generating config.py files #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would like to add one commit more that appends the "Default=" line to the comments above each config-parameter, and totally replicate the help-message. Currently the default-value is printed in the Should I do that? |
|
sure, that seems ok. |
|
With latest 2 commits now default-value are also printed on comments, and this PR is finished on my part. An additional change(169e849) is that the enum-choices are printed before the default-value. |
|
My apologies, just seen that there is a minor glitch in the generated configuration file (described in the review). |
ankostis
added a commit
to ankostis/traitlets
that referenced
this pull request
Aug 11, 2017
ankostis
added a commit
to ankostis/traitlets
that referenced
this pull request
Aug 12, 2017
+ Had to add an optional `as_rst=false` kwd in all`XxxEnum.info()` methods. + Added TCs for `info().
ankostis
added a commit
to ankostis/traitlets
that referenced
this pull request
Aug 12, 2017
+ Had to add `as_rst=false` kwd to all `XxxEnum.info()` methods. + Added TCs for `info()`.
ankostis
added a commit
to ankostis/traitlets
that referenced
this pull request
Aug 12, 2017
+ Had to add `as_rst=false` kwd to all `XxxEnum.info()` methods. + Added TCs for `info()`.
ankostis
added a commit
to ankostis/traitlets
that referenced
this pull request
Aug 12, 2017
+ Had to add `as_rst=false` kwd to all `XxxEnum.info()` methods. + Added TCs for `info()`.
ankostis
added a commit
to ankostis/traitlets
that referenced
this pull request
Aug 12, 2017
+ Had to add `as_rst=false` kwd to all `XxxEnum.info()` methods. + Added TCs for `info()`.
ankostis
added a commit
to ankostis/traitlets
that referenced
this pull request
Aug 12, 2017
+ Had to add `as_rst=false` kwd to all `XxxEnum.info()` methods. + Added TCs for `info()`.
ankostis
added a commit
to ankostis/traitlets
that referenced
this pull request
Aug 14, 2017
minrk
added a commit
that referenced
this pull request
Aug 15, 2017
fix(help): finish #381 for RsT to print enum-choices
Carreau
added
5.0-re-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating the
config.pyfile, explain the available enum-choices in the comment-lines, like help-message does.