Re-support multiple-alias key for ArgParseConfigLoader #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi folks, is there anything I can do to help get this merged? It seems to me that it should be a pretty straight-forward bug fix. Thanks in advance. |
|
Hi @azjps, I can review once you've resolved the merge conflict. |
Its sometimes useful to be able to support multiple aliases for the same trait, e.g. multiple shorthand abbreviations or supporting both underscores and dashes. Re-add support for an arbitrary number of aliases to be possible as a key in Application.aliases.
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its sometimes useful to be able to support multiple aliases for the same trait, e.g. multiple shorthand abbreviations or supporting both underscores and dashes. Re-add support for an arbitrary number of aliases to be possible as a key in
Application.aliasesand added a simple unit test.Closes #686