Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disambiguate the use of the term value in the example. #694

Merged
merged 1 commit into from
Mar 25, 2022
Merged

Disambiguate the use of the term value in the example. #694

merged 1 commit into from
Mar 25, 2022

Conversation

metaperl
Copy link
Contributor

The basic example in the docs is confusing because an attribute is named value (one use of value in the example) and the dictionary with the proposed-new-value has a key named value.

Because the dictionary key cannot be easily changed, I renamed the class attribute to data to disambiguate it.

@rmorshea rmorshea self-requested a review March 25, 2022 18:50
@Carreau
Copy link
Member

Carreau commented Mar 25, 2022

LGTM, failure unrelated. Thanks for taking the time !

@Carreau Carreau merged commit 2167802 into ipython:main Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants