Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix downstream test #701

Merged
merged 3 commits into from
Apr 12, 2022
Merged

Fix downstream test #701

merged 3 commits into from
Apr 12, 2022

Conversation

blink1073
Copy link
Member

No description provided.

@blink1073 blink1073 requested a review from Carreau April 8, 2022 02:45
pip freeze

- name: Run tests IPython
run: |
iptest
cd $HOME
Copy link
Contributor

@rmorshea rmorshea Apr 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why cd $HOME? I've never needed this when writing GitHub actions.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid using our own pytest.ini as the settings

@blink1073 blink1073 merged commit 26129b4 into ipython:main Apr 12, 2022
@blink1073 blink1073 deleted the fix-downstream-test branch April 12, 2022 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants