Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make __all__ explicit and validate in test #737

Merged
merged 3 commits into from
May 31, 2022

Conversation

blink1073
Copy link
Member

Fixes #736

@blink1073 blink1073 added the bug label May 31, 2022
@blink1073
Copy link
Member Author

cc @davidbrochart

Copy link
Contributor

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @blink1073 !

traitlets/tests/test_traitlets.py Outdated Show resolved Hide resolved
Co-authored-by: David Brochart <david.brochart@gmail.com>
@blink1073 blink1073 merged commit 63c8b83 into ipython:main May 31, 2022
@blink1073 blink1073 deleted the fix-typings branch May 31, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mypy errors
2 participants