Minor fixes for Application.aliases #810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
azjps
commented
Dec 7, 2022
azjps
commented
- Fix the type annotations for Applications.flags / aliases, which support tuples as keys and results in linting errors (e.g. in the test suite).
- Move the logic for determining what to do with an unrecognized command-line argument to a helper method. Currently a warning is logged, but in past versions of traitlets an error was raised, and this might be more user-friendly in some cases especially where the stderr can be pretty verbose (e.g. launching Jupyterlab).
The keys and values for Application.aliases and Application.flags require fairly specific types (in particular the keys can be tuples of string arguments), just writing them out. Update the corresponding comment.
Some applications may wish to have stricter handling for unrecognized command-line arguments in order to avoid accidental execution of a command-line which contains typos. (It might even be the preferred default behavior for many users.) Allow users to customize this behavior more easily by overriding KVArgParseConfigLoader._handle_unrecognized_alias.
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.