Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs version #880

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Fix docs version #880

merged 2 commits into from
Oct 17, 2023

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Oct 12, 2023 •
edited
Loading

References

The docs currently report the version as "__version__".

image

This PR fixes it to use __version__.

image

@ivanov ivanov added documentation 5.0-no-incidence change that has noincidence on 5.0 compat (eg: doc) labels Oct 17, 2023
ivanov
ivanov approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@ivanov ivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @bollwyvl

@ivanov ivanov merged commit fc130b2 into ipython:main Oct 17, 2023
30 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanov ivanov ivanov approved these changes

Assignees
No one assigned
Labels
5.0-no-incidence change that has noincidence on 5.0 compat (eg: doc) documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Traitlets documentation incorrectly shows __version__
2 participants
@bollwyvl @ivanov