Fix assigning string value to Set #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assigning a string value to a Set trait used to implicitly cast to a set containing the string, but it accidentally became a set of the string's characters after ipython#883. Fix this and add a unit test.
kraj
added a commit
to YoeDistro/meta-openembedded
that referenced
this pull request
Apr 19, 2024
Bring ipython/traitlets#903 on top of 5.14.2 release Signed-off-by: Khem Raj <raj.khem@gmail.com>
halstead
pushed a commit
to openembedded/meta-openembedded
that referenced
this pull request
Apr 21, 2024
Bring ipython/traitlets#903 on top of 5.14.2 release Signed-off-by: Khem Raj <raj.khem@gmail.com>
daregit
pushed a commit
to daregit/yocto-combined
that referenced
this pull request
May 22, 2024
Bring ipython/traitlets#903 on top of 5.14.2 release Signed-off-by: Khem Raj <raj.khem@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assigning a string value to a
Settrait used to implicitly cast to a set containing the string, but it accidentally was changed to become the set of the string's characters after #883. Fix this and add a unit test.Fixes #887 #891.