Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Vertiq2306 with new pulsing firmware. Added additional files … #31

Merged
merged 4 commits into from
May 31, 2023
Merged

Updated Vertiq2306 with new pulsing firmware. Added additional files … #31

merged 4 commits into from
May 31, 2023

Conversation

Vertiq-Ben
Copy link
Contributor

…for backwards compatibility

  • Added custom_iq_module because the old pulsing_module.py depended on it.

@Vertiq-Ben Vertiq-Ben requested a review from iq-fred May 30, 2023 21:04
iq-fred
iq-fred reviewed May 30, 2023
View reviewed changes
iqmotion/iq_devices/custom_iq_module.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This was on Bitbucket, but did not make it to Github yet. Adding it to keep them in sync and allow us to use the existing, backwards compatible Pulsing Module

iq-fred
iq-fred reviewed May 30, 2023
View reviewed changes
iqmotion/iq_devices/module_files/pulsing.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these pulsing additions already exist on Bitbucket, just moving them up to Github to keep them in sync and release it to the public

iq-fred
iq-fred reviewed May 30, 2023
View reviewed changes
iqmotion/iq_devices/vertiq2306_module.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same changes as on this Bitbucket PR: https://bitbucket.org/iqcontrol/python_api/pull-requests/48

iq-fred
iq-fred reviewed May 30, 2023
View reviewed changes
iqmotion/iq_devices/pulsing_module.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as on Bitbucket, keeping this around for "backwards compatibility" with users that were previously sent preliminary versions of pulsing API stuff

@Vertiq-Ben
Copy link
Contributor Author

Corresponding BitBucket PR: https://bitbucket.org/iqcontrol/python_api/pull-requests/48

@Vertiq-Ben Vertiq-Ben merged commit cb2f997 into development May 31, 2023
2 checks passed
@Vertiq-Ben Vertiq-Ben deleted the refactor-pulsing-module branch June 7, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iq-fred iq-fred iq-fred approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Vertiq-Ben @iq-fred