Add OCaml Tuareg mode to exceptions

[leafac]

OCaml comments read as (* Some comment *). But the *)
translates to 😉, which is not intended.

[ryanprior]

This patch is a good use case for enabling or disabling emojification per mode and emoji type. Am I right to assume that OCaml Tuareg mode would be fine rendering fenced and Unicode emojis?

[leafac]

@ryanprior First, thanks for the incredibly quick feedback.

I guess you're right. I see no reason why Tuareg mode would not be fine rendering fenced and Unicode emojis. So I'm going to change this PR to disable emojification only for Tuareg mode and the *) type emoji.

[leafac]

@ryanprior I couldn't immediately find an obvious way of achieving that. I'm going to be busy for the rest of the day, so this is going to have to wait until tomorrow.

[iqbalansari]

@leafac First of all, sorry for any inconvenience caused by this and thanks for the patch.

Actually emojify by default displays emojis only in comments and strings in programming modes, so this should have not happened. The issues is that to check if the current major-mode is a programming mode, emojify uses (derived-mode-p 'prog-mode). The expression returns nil for tuareg since it is in fact derived from tuareg--prog-mode.

So a better fix would be to teach emojify about tuareg--prog-mode. I have pushed a (temporary) fix to develop, will merge with master once the tests pass. I call the fix temporary since although this fixes the issue at hand, I think emojify needs a better check for programming modes.

@ryanprior

This patch is a good use case for enabling or disabling emojification per mode and emoji type

I think you have a point (although it would not have helped in present issue). I have opened #13 to track this.

[leafac]

@iqbalansari Thanks for the lighting fast fix! And thanks for teaching me about the internals of emojify. I'm going to go ahead and close this PR.

[leafac]

I updated to the latest version of emojify, including 3b9a4bc, and can confirm the issue has been fixed.

Thanks!

[iqbalansari]

Great! Thanks for confirming 😄