Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against Stargate/Tendermint 0.34 #144

Closed
zmanian opened this issue Oct 5, 2020 · 3 comments
Closed

Test against Stargate/Tendermint 0.34 #144

zmanian opened this issue Oct 5, 2020 · 3 comments
Assignees

Comments

@zmanian
Copy link
Contributor

zmanian commented Oct 5, 2020

Tendermint 0.34 is expected to be backwards compatible in the block signing proposal.

It is possible to drop amino entirely and use protobuf for Tendermint 0.34 signing and we should but the bytes on the wire should be identical. We should validate this week.

@tony-iqlusion @Shella

@ebuchman
Copy link
Contributor

ebuchman commented Oct 6, 2020

We're wrapping up a major overhaul to tendermint-rs this week and should be able to help update the KMS to it - includes dropping all Amino and replacing with protobuf.

@tony-iqlusion
Copy link
Member

Current testing status is we've managed to have TMKMS complete the secret connection handshake with Tendermint v0.34 on the stargate-4 testnet.

It's managed to sign blocks and respond, however the signature/canonicalization logic is still using Amino encoding, so the signatures were rejected:

I[2020-10-29|19:18:26.445] Committed state                              module=state height=215762 txs=0 appHash=D6355CC836C19919CA5E61EC13CEC1B0D8DDF4F4B746149CBD9DEDEEF85F0EC2
E[2020-10-29|19:18:31.510] Error with msg                               module=consensus height=215763 round=0 peer= err="error adding vote" msg="[Vote Vote{4:8D958F00F757 215763/00/SIGNED_MSG_TYPE_PREVOTE(Prevote) 070FFAC5FF65 E615807F7779 @ 2020-10-29T23:18:31.354047807Z}]"
E[2020-10-29|19:18:31.940] Error with msg                               module=consensus height=215763 round=0 peer= err="error adding vote" msg="[Vote Vote{4:8D958F00F757 215763/00/SIGNED_MSG_TYPE_PRECOMMIT(Precommit) 070FFAC5FF65 70712338B911 @ 2020-10-29T23:18:31.786940937Z}]"
I[2020-10-29|19:18:32.054] Executed block                               module=state height=215763 validTxs=0 invalidTxs=0

@tony-iqlusion
Copy link
Member

TMKMS is definitely Stargate-compatible at this point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants