Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use importlib.util for better support #39

Merged

Conversation

nikosavola
Copy link
Contributor

Fix user reported bug for certain environments by being more specific in imports

Closes #38

@nikosavola nikosavola added bug Something isn't working FEM Finite Element simulations labels Feb 3, 2023
@nikosavola nikosavola self-assigned this Feb 3, 2023
@nikosavola nikosavola linked an issue Feb 3, 2023 that may be closed by this pull request
@cla-bot cla-bot bot added the cla-signed label Feb 3, 2023
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

Test results

       6 files  ±0         6 suites  ±0   3m 26s ⏱️ -31s
   261 tests ±0     261 ✔️ ±0  0 💤 ±0  0 ±0 
1 566 runs  ±0  1 566 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit a6aa73e. ± Comparison against base commit 49daec4.

@caspar-iqm
Copy link
Member

I think this change is technically required indeed. Even though I never got an error on this, the Pycharm code checker flags this issue on python 3.10.5.

I could imagine the following dynamic behavior: if importlib.util has ever been imported somewhere, it probably exists in the scope of importlib for the remainder of the python session.

Copy link
Contributor

@qpavsmi qpavsmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense

@qpavsmi qpavsmi merged commit daa4637 into main Mar 22, 2023
@qpavsmi qpavsmi deleted the 38-simulations-module-importlib-has-not-attribute-util branch March 22, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla-signed FEM Finite Element simulations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simulations: module 'importlib' has not attribute 'util'
3 participants