Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HangerResonator #70

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Conversation

iqmtestd
Copy link
Contributor

It uses the more efficient WaveguideCoplanar and thus also avoids recursive element usage (disallowed by KLayout) when insertend in WaveguideComposite.

Fix #69

It uses the more efficient WaveguideCoplanar and thus also avoids recursive
element usage (disallowed by KLayout) when insertend in WaveguideComposite.

Fix #69
@cla-bot cla-bot bot added the cla-signed label Oct 20, 2023
@iqmtestd iqmtestd requested a review from qpavsmi October 20, 2023 11:49
@github-actions
Copy link

Test results

       5 files  ±0         5 suites  ±0   3m 30s ⏱️ -18s
   333 tests ±0     332 ✔️ ±0  1 💤 ±0  0 ±0 
1 665 runs  ±0  1 660 ✔️ ±0  5 💤 ±0  0 ±0 

Results for commit ef928b2. ± Comparison against base commit a767105.

Copy link
Contributor

@qpavsmi qpavsmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, we can finally use the hanger resonator in the waveguidecomposite

@iqmtestd iqmtestd merged commit 45db703 into main Oct 20, 2023
18 checks passed
@iqmtestd iqmtestd deleted the 69-hangerresonator-breaks-waveguidecomposite branch October 20, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HangerResonator breaks WaveguideComposite
2 participants