Use get_run_status() instead of get_run() to check status #100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
wait_for_results()
andwait_for_compilation()
usedget_run()
to check the status of the job. The RunResult returned byget_jobs()
contains metadata which contains the original job request, so if the original job request was large, it could take a long time to send and decode the RunResult JSON even before job results are ready. This meant that, for example,wait_for_results()
might end up checking the status only every 30 seconds (because of the RunResult overhead) while it was supposed to check the status once every second. With unlucky timing, this could then lead to a situation where the job has already finished on the server, butwait_for_results()
returnsAPITimeoutError
long after that.This MR fixes the problem by using
get_run_status()
instead ofget_run()
to check the status inwait_for_results()
andwait_for_compilation()
, so that only RunStatus is polled, not RunResult.